Draw status badges from a parked block's held outcome - #491
Merged
Merged
Conversation
Core no longer reports `dormant` for a block out of the eval set, so the case that mapped it to `NA`, telling a persistent renderer to keep its last badge, could not be reached. Drop it and `NA` from the documented return value.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This was referenced Sep 29, 2026
Closed
nbenn
marked this pull request as ready for review
September 30, 2026 11:31
This was referenced Sep 30, 2026
nbenn
added a commit
that referenced
this pull request
Sep 30, 2026
The badge docs keep this branch's wording without the `NA` return, and the style test keeps the token assertions with #491's `unevaluated` loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
staleonce that is out of date, orunevaluatedwithout one, and neverdormant. Thedormantcase inblock_status_badge(), which returnedNAso that a persistent renderer such as the blockr.dag node kept the badge it drew last, could no longer be reached. It goes, along withNAin the documented return value.evaluaterequest reads its heldfailedonce parked and draws the failed badge.unevaluatedblock that has raised an error still draws the failed badge, asreadydoes. Its errors come from the expression server, which runs while the block is parked, so unlike a stale block's they cannot predate a check.staleeval status on the block status badge #408 NEWS entry says "parked" where it said "dormant", as core did for its own unreleased entries.Fixes #485